FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Extract float formatting into a static method to use with to_json by evaniainbrooks · Pull Request #9200 · jruby/jruby · GitHub

/ jruby Public

Extract float formatting into a static method to use with to_json - #9200

Merged
headius merged 1 commit into
jruby:masterfrom
evaniainbrooks:float-formatter
Jan 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Extract float formatting into a static method to use with to_json#9200
headius merged 1 commit into
jruby:masterfrom
evaniainbrooks:float-formatter

Conversation

evaniainbrooks commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

headius marked this pull request as ready for review January 29, 2026 23:43

headius commented Jan 29, 2026

Copy link
Copy Markdown
Member

@evaniainbrooks This is great, thank you!

The spec should probably go in spec/ruby if that behavior is not already in specs, and we'll probably want to backport this to 9.4 so the json gem doesn't break for future versions, but this could probably go into 10.0.3.0 to get the json work moving forward.

Requesting review from @enebo.

headius requested a review from enebo January 29, 2026 23:46
headius added this to the JRuby 10.0.3.0 milestone Jan 29, 2026

evaniainbrooks commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

I reverted the added spec because this is certainly already covered in spec/ruby/core/float/shared/to_s.rb

headius approved these changes Jan 30, 2026
View reviewed changes

headius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. I will backport to 9.4 since we will need the json gem to keep working there once it starts using this API.

headius merged commit ea1ea89 into jruby:master Jan 30, 2026
75 of 76 checks passed

headius commented Jan 30, 2026

Copy link
Copy Markdown
Member

@evaniainbrooks Thank you! Let me know if I can do anything else to help.

This was referenced Jan 30, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

headius headius approved these changes
enebo Awaiting requested review from enebo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 10.0.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL