Invalidate method caches from generated populators - #9203
Merged
headius merged 2 commits intoJan 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Generated method populators use `putMethod` directly to avoid the overhead of invalidating method caches before any user code runs, but this breaks when a generated populator is used after boot time. As described in jruby#9196, this can cause methods added by generated populators to be shadowed by previously-cached results, such as the undefined marker cached for missing methods. The logic here modifies the generated populators to invalidate any classes they've modified, but only once per populator and only if we are no longer booting the JRuby core classes.
headius
enabled auto-merge
January 30, 2026 03:51
headius
disabled auto-merge
January 30, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a fix and test for invalidating method caches on classes modified by our generated populators (from AnnotationBinder). If we are booting core, no invalidation happens, but for extensions loaded after that point we should be invalidating to avoid leaving shadow cache entries as described in #9196.