FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for cloned class singleton class has too many ancestors by evaniainbrooks · Pull Request #9239 · jruby/jruby · GitHub

/ jruby Public

Fix for cloned class singleton class has too many ancestors - #9239

Merged
headius merged 1 commit into
jruby:ruby-4.0from
evaniainbrooks:9238-singleton-ancestors
Feb 18, 2026
Merged

Fix for cloned class singleton class has too many ancestors#9239
headius merged 1 commit into
jruby:ruby-4.0from
evaniainbrooks:9238-singleton-ancestors

Conversation

Copy link
Copy Markdown
Contributor

issue #9238

evaniainbrooks marked this pull request as ready for review February 16, 2026 00:08

headius commented Feb 18, 2026

Copy link
Copy Markdown
Member

Looks right. Regressions in JRuby tests are due to an inspect change I made that does not appear to be necessary after this fix. I'll sort it out.

headius added this to the JRuby 10.1.0.0 milestone Feb 18, 2026
headius merged commit 0823d6e into jruby:ruby-4.0 Feb 18, 2026
45 of 79 checks passed
headius added a commit that referenced this pull request Feb 18, 2026
The infinite recursion happening before seems to have been a side
effect of adding too many metaclasses into the hierarchy when
getting the singleton class of a class (see #9238, fixed
by #9239).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL