Check if respond_to_missing? exists before respond_to? - #9280
Merged
headius merged 1 commit intoMar 3, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Old logic did a hard dispatch to respond_to_missing? if respond_to? returned false. This breaks any case where respond_to_missing? has been removed from a class altogether. The change here tries to mimic the CRuby logic, first checking if respond_to? exists and returns true, and if it does not, only call respond_to_missing? if it exists. Fixes jruby#9258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old logic did a hard dispatch to respond_to_missing? if respond_to? returned false. This breaks any case where respond_to_missing? has been removed from a class altogether.
The change here tries to mimic the CRuby logic, first checking if respond_to? exists and returns true, and if it does not, only call respond_to_missing? if it exists.
Fixes #9258