| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
It's not great practice to be mix+matching mvn and mvnw; since it risks inconsistency. When Maven 4 comes out this practice will cause headaches :-) Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Don't think it's necessary to lock these independently; they can probably just use the version implied by the source control version. Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
There was a problem hiding this comment.
Looks good. I must admit I find the ./mvnw everywhere to be a bit verbose but the consistent build behavior is worth it.
Sorry, something went wrong.
|
An exercise for another time would be to further reduce duplication between these jobs. Most of these jobs have only a few lines of difference. |
Sorry, something went wrong.
Yeah, I'm in two minds myself about the value of the wrappers (and needing to upgrade them) however having two approaches undermines it. So seems better to me to use mvn everywhere or the wrappers everywhere. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Cleans up the build process for improved consistency:
Build
GitHub Actions