Don't read or write anything once length is zero - #9415
Merged
headius merged 2 commits intoMay 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
A zero-length copy_stream fell through the cracks along the non-IO path, failing to detect that nothing should be transferred and proceeding to copy the maximum chunk size repeatedly. This caused jruby#9377 and resulted in zero-length files from gems being written with the entire contents of the remaining tar stream. The fix here detects a zero length on the way into each form of transfer and bails out before any work is done. Fixes jruby#9377.
headius
force-pushed
the
zero_length_copy_stream_non_io
branch
from
8957684 to
bb1f49f
Compare
May 5, 2026 21:48
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9377.