ivarSet missing return after megamorphic fallback - #9425
Merged
headius merged 1 commit intoMay 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
headius
approved these changes
May 8, 2026
headius
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
You are correct. This logic could be cleaned up (and hopefully will be soon).
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
observed with debug (using log.binding)
before the fix, a megamorphic site logged"failed (polymorphic)" followed by a "bound directly" for the same type.
seems to me like this isn't intentional esp. given the ivarGet logic ends up returning after invokedynamic.maxpoly is reached...