Invalidate prepended origin module as well as subclasses - #9598
Merged
headius merged 2 commits intoAug 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
When a module is prepended into another module, there's no subclass relationship for normal down-hierarchy invalidation. Instead, we actively invalidate the origin module's including hierarchies as well as classes down the hierarchy. Fixes jruby#9589
For jruby#9589, we discovered that modules with prepends did not properly invalidate class hierarchies they have been included into, due to the method table being moved to the prepend shim and only invalidating along that hierarchy. This spec tests that such a module continues to invalidate included hierarchies when its method table is modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a module is prepended into another module, there's no subclass relationship for normal down-hierarchy invalidation. Instead, we actively invalidate the origin module's including hierarchies as well as classes down the hierarchy.
PrependedModule becomes the new location for the origin's method table, so when it is updated the origin must also be invalidated.
There's probably too much complexity here and this might be fixable by also moving the included hierarchies into the PrependedModule, but I did not validate that all places updating this hierarchy are aware of the methodLocation. An audit of this logic should probably happen at some point, and PrependedModule might be better renamed to RelocatedClassGuts but with a better name, to indicate that it is now the new location for the origin's state. That work is out of scope for this quick fix.
Fixes #9589
Draft until specs are added.