Fix asn1data - objectid - #336
Open
HoneyryderChuck wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
it's supposed to raise on der encoding (not initialization), and it's supposed to be an ASN1Error (not TypeError) exception
same behaviour as upstream now, it compares the translated oid strings
the existing batch wasn't synched; commented the test around registering of nids
HoneyryderChuck
force-pushed
the
fix-asn1data-2
branch
from
101c47d to
5879e37
Compare
July 30, 2025 15:30
Copy link
Copy Markdown
Member
|
there seems to be a regression with the existing tests, reported by the CI: Failure: test_subject_alt_name_sign_to_pem(TestX509Extension)
/home/runner/work/jruby-openssl/jruby-openssl/src/test/ruby/x509/test_x509ext.rb:199:in `test_subject_alt_name_sign_to_pem'
196: csr = OpenSSL::X509::Request.new pem = csr.to_pem
197: assert_equal 2, csr.attributes.length
198: ext_set = csr.attributes.first.value ; seq = ext_set.first.value
=> 199: assert_equal 'subjectAltName', seq.first.value.first.value
200: dns = seq.first.value.last.value
201: assert dns =~ /test.example.com.*?test2.example.com.*?example.com.*?www.example.com/
202: end
org/jruby/RubyKernel.java:1189:in `catch'
org/jruby/RubyKernel.java:1184:in `catch'
org/jruby/RubyArray.java:1820:in `each'
org/jruby/RubyArray.java:1820:in `each'
org/jruby/RubyKernel.java:1189:in `catch'
org/jruby/RubyKernel.java:1184:in `catch'
<"subjectAltName">(US-ASCII) expected but was
<"2.5.29.17">(UTF-8)
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
this seems stale at this point, some of the added tests don't pass on MRI |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ruby-openssl objectid tests + fixing the discrepancies.