1.x: Avoid removing files not ended in .rb - #452
Closed
pacop wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I was not able to pass specs, neither in travis nor my pc. Force-pushed to try again, but it was unsuccessful |
Sorry, something went wrong.
Comment thread
lib/warbler/task.rb
| task @name do | ||
| rm_f config.compiled_ruby_files.map {|f| f.sub(/\.rb$/, '.class') } | ||
| extensions = config.compiled_ruby_files&.map { |f| File.extname(f) }&.uniq || ['.rb'] | ||
| regex_extensions = extensions.map { |extension| extension.sub('.', '\.') }.join('|') |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RegExp.union is pretty great:
extensions = Pathname.glob("config/**/*").map(&:extname).uniq
# [".pem", ".rb", ".yml", ".ignore", "", ".md", ".markdown", ".json"]
Regexp.union(extensions)
# /\.pem|\.rb|\.yml|\.ignore||\.md|\.markdown|\.json/
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the option compiled_ruby_files is personalized to use different extensions, for instance, .rake files. They are removed each time warble is called.
Problem was in lib/warbler/task.rb where every file not ended in .rb were being removed.