FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix bug with gem_excludes not being used on bundler gems by fzakaria · Pull Request #468 · jruby/warbler · GitHub

/ warbler Public

Fix bug with gem_excludes not being used on bundler gems - #468

Closed
fzakaria wants to merge 1 commit into
jruby:masterfrom
fzakaria:upstream-git-fix
ConversationCommits (1)ChecksFiles changed
Closed

Fix bug with gem_excludes not being used on bundler gems#468
fzakaria wants to merge 1 commit into
jruby:masterfrom
fzakaria:upstream-git-fix

Conversation

fzakaria commented Jan 28, 2020

Copy link
Copy Markdown

This is an upstream commit authored by @stalbot.

Unclear why in the original code exclude_gems was set to false if any files were found in the Git gem. It caused the condition to check for config.gem_excludes to not trigger.

(Looks like gem_excludes will not work neither when spec.source is ::Bundler::Source::Path)

Co-authored-by: Steven Talbot steven@looker.com

fzakaria requested a review from headius February 5, 2020 02:10

fzakaria commented Feb 5, 2020

Copy link
Copy Markdown
Author

Would a test be needed for this change ?
I'd like to make sure it gets merged.

fzakaria commented Feb 5, 2020

Copy link
Copy Markdown
Author

The Travis failures are not related to the change:

Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    jbundler (~> 0.9) java was resolved to 0.9.3, which depends on
      bundler (~> 1.5) java
  Current Bundler version:
    bundler (2.1.4)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

kares commented Feb 9, 2020

Copy link
Copy Markdown
Member

yes, please possibly add a test regardless of CI

fzakaria commented Feb 11, 2020

Copy link
Copy Markdown
Author

The unit tests are more complicated -- this might take me a little bit.
I've never heard of DRB :)

What's the state of Warbler ?
Is it still the recommended approach by JRuby to build a JAR?

I'm curious due to the state of the CI.

chadlwilson commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sorry, didn't notice this old PR. Fixed as part of #650 using same approach.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

headius Awaiting requested review from headius

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL