FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Exploded war support by kovyrin · Pull Request #484 · jruby/warbler · GitHub

/ warbler Public

Exploded war support - #484

Draft
kovyrin wants to merge 9 commits into
jruby:masterfrom
kovyrin:kovyrin/exloded-war
Draft

Exploded war support#484
kovyrin wants to merge 9 commits into
jruby:masterfrom
kovyrin:kovyrin/exloded-war

Conversation

kovyrin commented Jun 11, 2020

Copy link
Copy Markdown

WIP exploded war support

kovyrin closed this Oct 26, 2020

headius commented Oct 26, 2020

Copy link
Copy Markdown
Member

Hey I had not noticed this PR... is it not valid anymore? I think the exploded war support would be great to get working!

kovyrin commented Oct 26, 2020
edited
Loading

Copy link
Copy Markdown
Author

Oh, sorry for not providing more context here. The PR worked for us, but then, to make things cleaner and easier for us, I decided to move away from using warbler's main class and pushed everything into pure jruby (basically, java -cp "$JRUBY_STDLIB:$JRUBY_JAR" org.jruby.Main -r rubygems -x"$ENT_SEARCH_WAR_ROOT" -S bin/enterprise-search-internal and then configuring and booting up Jetty from within our custom ruby code), so the need in warbler support for exploded wars went away.

If this kind of support may be helpful, I'd be OK with someone taking my code (which is not too different from the existing main class) and running with it, but, unfortunately, I'm not sure I have the time to push this over the finish line and get it merged.

headius commented Oct 27, 2020

Copy link
Copy Markdown
Member

@kovyrin If you don't mind, I'll reopen this and pull in some other JRuby folks to discuss whether it's a useful feature to add. Thanks for the clarification!

headius reopened this Oct 27, 2020

headius commented Oct 27, 2020

Copy link
Copy Markdown
Member

@kares @mkristian @enebo @jkutner Is this something we want to pursue?

kares commented Mar 25, 2023

Copy link
Copy Markdown
Member

seems unfinished, would be nice if this was integrated with the existing (WarMain) "main" classes.
we could leave it open as a draft or close, your call ...

chadlwilson changed the title Exloded war support Exploded war support Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL