Adding proper argument parsing and building methods. - #3
Open
jarulsamy wants to merge 9 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The old way of building was difficult and cumbersome. This way, there is no need to link against other projects src. Added all the necessary headers that aren't installed by other libs.
Previosuly the locations for combo.dict and the input raw file were both hardcoded, now they are command line arguments. Adds a TON of flexibility.
* Removed extra headers * Reordered headers to be more readable. * Reorganized repository
jarulsamy
marked this pull request as ready for review
May 27, 2020 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey James,
I changed a few things,
Things to note:
I revamped the entire command parsing system. So playing the sounds is a little different. Please refer to the readme and test accordingly. If anything is not functioning properly please let me know. Although, I think this is production ready for phoneclearly.