| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
great job! thanks for handling this! |
Sorry, something went wrong.
|
According to this PR #1127, i've added a schema to validate requests that update a resource or relationship. |
Sorry, something went wrong.
|
Actually, the JSON schema for v1.0 uses the draft-07 version. |
Sorry, something went wrong.
|
1.1 should be latest jsonschema compliant, like openAPI 3.1 does, IMHO. |
Sorry, something went wrong.
|
Could someone tell me what is missing for this PR to be merged ? |
Sorry, something went wrong.
There was a problem hiding this comment.
Addressing typo found during CI integration with Drupal's dictionary. s/forbiden/forbidden
Sorry, something went wrong.
| "type": "object", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/relationshipsForbidenMemberName" |
There was a problem hiding this comment.
| "$ref": "#/definitions/relationshipsForbidenMemberName" | |
| "$ref": "#/definitions/relationshipsForbiddenMemberName" |
Sorry, something went wrong.
| "type": "object", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/relationshipsForbidenMemberName" |
There was a problem hiding this comment.
| "$ref": "#/definitions/relationshipsForbidenMemberName" | |
| "$ref": "#/definitions/relationshipsForbiddenMemberName" |
Sorry, something went wrong.
| }, | ||
| "unevaluatedProperties": false | ||
| }, | ||
| "relationshipsForbidenMemberName": { |
There was a problem hiding this comment.
| "relationshipsForbidenMemberName": { | |
| "relationshipsForbiddenMemberName": { |
Sorry, something went wrong.
|
Corrected. |
Sorry, something went wrong.
To be honest I'm not an expert for JSON schema. But I agree that we need to improve in that regard. Thanks a lot for following up. Personally I would feel much more comfortable with reviewing if we would have some test coverage for the schema. Like having a set of JSON:API documents, which are validated with the schema in CI. Also it's unclear to me how we could version the schema. v1.1 is not stable yet formally. We might need at least two schemas: one for the current stable version and one for the upcoming version. We may want to setup such an infrastructure before moving forward. |
Sorry, something went wrong.
|
Just had a look at the proposed changes in this PR and noticed that it is already addressing some points I raised above. Seems to be a great starting point! 👏 |
Sorry, something went wrong.
|
yes there is another PR for the v1.0 :) #1600 |
Sorry, something went wrong.
|
I really appreciate this work and its importance for the spec. In my opinion, an official schema is not a blocker for the v1.1 release but it would be ideal to release both simultaneously. I think we stand a good chance to finalize the schema in the same time frame that the final v1.1 RC is being reviewed, without delaying either. |
Sorry, something went wrong.
thats a reasonable plan |
Sorry, something went wrong.
Add meta member to all test files with informations about errors present in the document.
|
Is there anything that is blocking this PR? :) Should I do something? Thank you |
Sorry, something went wrong.
There was a problem hiding this comment.
I think we can move with it after we complete merging the schema for v1.0
Sorry, something went wrong.
|
in fact we can move with it in 1.1 branch as well. in case v 1.0 need more work? |
Sorry, something went wrong.
|
We must validate and merge v1.0 before merging it in 1.1 branch because this PR uses the validation script that is introduced in the #1600 (./_schemas/scripts/validator.js). |
Sorry, something went wrong.
|
Ok great. Lets complete the v1.0 first |
Sorry, something went wrong.
|
v1.0 seems complete, validator is merged. Think this could move forward. |
Sorry, something went wrong.
|
Any chance this could be merged ^^ |
Sorry, something went wrong.
Pins the four unreleased JSON:API 1.1 draft-PR schemas (json-api/json-api#1603) and validates writer-generated bytes offline against them; schema acceptance is supplemental evidence only.
| Back | FazBrowse Home | New Git URL |
I've only added sample files in relation with the new features of the 1.1 version.
I still have to add the rules regarding the @-members and the extension members.
Coming soon...