This repository was archived by the owner on Jul 22, 2026. It is now read-only.
Ensure all watchers validate for the Id - #592
Merged
jujubot merged 1 commit intoNov 30, 2021
Merged
jujubot merged 1 commit into
jujubot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
SimonRichardson
force-pushed
the
watcher-rpc-id-checker
branch
from
ef2cb78 to
8266032
Compare
November 25, 2021 10:24
Currently all watchers in Juju are expected to ensure that they pass back an id. This is currently done per watcher, what should actually happen is we should correctly wire up the calls to the facades, but this doesn't seem easy. Instead, this approach ensures that all watchers when doing an RPC call have a Id. If no Id is present raise an error so that the correct watcher id can be passed in.
SimonRichardson
force-pushed
the
watcher-rpc-id-checker
branch
from
8266032 to
aafab7c
Compare
November 25, 2021 10:33
cderici
approved these changes
Nov 29, 2021
cderici
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I assume the problems in the CI tests are not related. Do you already know what's going on there or should we investigate?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
!!build!! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
$$merge$$ |
Sorry, something went wrong.
jujubot
added a commit
that referenced
this pull request
Dec 4, 2021
#599 2.9.5 ^^^^^ Friday December 3 2021 * remove the event loop arguments by @cderici in #560 * add debug-log by @cderici in #562 * Model status by @juanmanuel-tirado in #563 * Pin cffi version to 1.14.6 for Python 3.5 by @cderici in #570 * Wait for applications to terminate on model reset by @balbirthomas in #572 * Babysitting python3.5 by @cderici in #571 * Deploy charmhub bundles by @cderici in #569 * Facade schemas for 2.9.17 by @SimonRichardson in #579 * Bundles with overlays by @cderici in #566 * Consistently getting a unit's public address by @cderici in #573 * [JUJU-158] Add python3.9 to setup.py by @cderici in #585 * [JUJU-157] Add note for removing services by @cderici in #583 * Added boolean entries to normalize values. by @juanmanuel-tirado in #582 * [JUJU-138] Streamlining asyncio tasks/events by @cderici in #580 * [JUJU-234] Fix for small bug in task handling by @cderici in #589 * Ensure all watchers validate for the Id by @SimonRichardson in #592 * [JUJU-276] Facade schemas for 2.9.19 by @cderici in #594 * [JUJU-238] Small bug fix for old ClientFacade support by @cderici in #593 * [JUJU-239] Debug-log parameters by @cderici in #595 * [JUJU-213] Local type `file` resource support by @cderici in #590 * [JUJU-289] Use provided series in deploy if supported by @jack-w-shaw in #596 * [JUJU-292] Update the charms in the tests to use Charmhub by @cderici in #597 * Legacy "services" for describing "applications" within bundles are no longer supported. "applications" can be used as a direct replacement for "services" in bundles.yaml. * The websocket (ws) in a Connection object became a read-only property. [JUJU-293] [JUJU-158]: https://warthogs.atlassian.net/browse/JUJU-158?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all watchers in Juju are expected to ensure that they pass
back an id. This is currently done per watcher, what should actually
happen is we should correctly wire up the calls to the facades, but this
doesn't seem easy. Instead, this approach ensures that all watchers when
doing an RPC call have a Id. If no Id is present raise an error so that
the correct watcher id can be passed in.