Allows for providing a custom secret name on the consumer side. Random secret is non-deterministic and hard to reason on UI (where it came from)
Allows to run deploy when image is swapped with hash (not released version)
Report consumer secret into provider cluster binding so we can use that to generate commands like:
So we know what secret to reference for user
What Type of PR Is This?
Related Issue(s)
Fixes #
Release Notes
Add consumer to provider secret reporting (name/namespace)
Dont fail `kubectl bind deploy` when incluster image is hash based (override)
Allow named secret on consumer side in CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr has few things:
So we know what secret to reference for user
What Type of PR Is This?
Related Issue(s)
Fixes #
Release Notes