feat(stack): render stack blocks as nested topology - #37
Closed
aryasaatvik wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
hungmuha
approved these changes
Jul 13, 2026
hungmuha
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM — nested-topology rendering is correct across fork/deep/cycle/round-trip cases with solid new test coverage. Two minor nits:
- nit src/stackGraph.ts:195 — displayChainFor no longer has a production caller after Stack.ts switched to displayTreeFor; only its definition, the interface member, the return-object entry, and StackGraph tests reference it. If not intended as retained API, remove it and its stale tests; otherwise note it is test-only.
- nit src/stackBlock.ts:116 — line() appends a branch-label suffix in backticks, but completedLines parses the branch key via the first backtick group. With showTitles (GitLab), a PR/MR title containing backticks makes the first group match the title fragment instead of the branch, so the next sync resolves the wrong key and strips the title inline code. Low likelihood/cosmetic, but the round-trip is lossy. Consider anchoring the branch-label match to end-of-line.
Sorry, something went wrong.
Copy link
Copy Markdown
|
oh this would be lovely |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render managed Stack blocks as nested Markdown lists so the visible widget matches the PR/MR target-branch topology. The block still preserves landed history above the open stack, but open siblings from stale flat blocks are no longer mistaken for history.
Examples
Linear stack with the middle PR current:
Forked stack with siblings under the same parent:
Landed history remains above the open stack:
Validation