refactor(stack): simplify internals and avoid redundant work - #51
Merged
kitlangton merged 1 commit intoAug 28, 2026
Merged
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Reuse model fields and existing test fixtures, remove dead private repair state, and preserve checkpoint and undo behavior. Limit branch-specific worktree inspection to owners, read state files directly, and let static skill output run outside Git. Rely on prepack for a single packaging build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The codebase repeats model projections, test setup, and private repair state that can be derived from existing values. Branch-specific Git operations also inspect unrelated worktree contents, and the packaging smoke command builds the same CLI twice.
The whole-codebase simplification pass keeps the existing service boundaries and safety checks while removing that duplication and unnecessary work.
What Changes
Recovery Invariants
Replacement requests still checkpoint before creation and again after recording the created request number. Branch backups, per-remote leases, journal versions, cumulative keep-going recovery, and read-only retry policy are unchanged. No Git observations are cached across mutations.
Scope
Small local simplifications across the codebase, not an architectural rewrite. Public service interfaces and persisted schemas are unchanged. Includes a patch changeset for the skill fix and reduced local work; it does not change the release already published as 0.4.5.
Verification
GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_SYSTEM=/dev/null bun run test bun run typecheck bun run format:check bun run lint bun run package:smoke bun run changeset:status --since origin/main bun src/cli.ts --help bun src/cli.ts skill --help git diff --check211 tests pass on both Apple Git 2.50.1 and a locally built Git 2.39.5. Existing test assertions are retained, including real squash-merge and leased-undo coverage. Eleven new regressions cover outside-repository skill output, owner-only worktree inspection, dirty-owner refusal, full inspection, and missing/valid/corrupt/permission-denied state reads.
Inspected the packed tarball, installed it into a clean consumer, and ran its installed stack skill outside Git plus stack --version. The smoke command now invokes one build through prepack.