Avoid overriding "pipe" option with "quiet" - #538
Open
ArchieMeng wants to merge 2 commits into
Open
ArchieMeng wants to merge 2 commits into
ArchieMeng wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: ArchieMeng <archiemeng@protonmail.com>
ArchieMeng
marked this pull request as ready for review
April 29, 2021 08:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is related to #195 #417
PR #417 has fixed the issue #195 , but overriding pipe_stdout and pipe_stderr options.
There is a situation in my project where the video decoding subprocess need to mute stderr while piping frames via stdout to python process. With the current "quiet" implementation, the pipe_stdout will be muted.
In fact, this is still under testing, but reviews are welcome.
Signed-off-by: ArchieMeng archiemeng@protonmail.com