cluster: migrate registry from host container to in-cluster deployment by lkingland · Pull Request #3856 · knative/func · GitHub

Summary

Migrates func cluster create from running a standalone func-registry container on the host to deploying the registry as in-cluster Kubernetes resources, matching the approach already taken in hack/cluster.sh (PR #3718).

What changed:

Registry is now a Deployment + ClusterIP Service + Contour Ingress inside the Kind cluster (was a host-side docker run container with ExternalName Service)
registryAddr is registry.localtest.me (was localhost:50000)
Containerd mirrors point at http://localhost:5000 via hostPort (was http://func-registry:5000 via Docker network DNS)
Each cluster owns its own registry, destroyed automatically by kind delete cluster
Delete flow simplified: no shared container teardown needed
Removed: ensureRegistry, registryStatus, teardownRegistry, setupPodmanMacOSForwarding, and all host-container lifecycle constants

What's preserved:

Host trust config (Docker daemon.json / Podman registries.conf) — now uses registry.localtest.me
--skip-registry-config flag behavior unchanged
Last-cluster check for host trust revert
Kubeconfig stat guard in Delete() to suppress noisy warnings on orphan-cleanup path

Codecov Report

❌ Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.48%. Comparing base (da6327e) to head (05b13f2).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cluster/registry.go	0.00%	71 Missing ⚠️
pkg/cluster/delete.go	0.00%	14 Missing ⚠️
pkg/cluster/kubernetes.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3856      +/-   ##
==========================================
+ Coverage   53.43%   53.48%   +0.05%     
==========================================
  Files         200      200              
  Lines       23405    23381      -24     
==========================================
- Hits        12506    12505       -1     
+ Misses       9649     9626      -23     
  Partials     1250     1250

Flag	Coverage Δ
e2e	33.73% <0.00%> (+0.03%)	⬆️
e2e go	29.61% <0.00%> (+<0.01%)	⬆️
e2e node	25.90% <0.00%> (+<0.01%)	⬆️
e2e python	29.94% <0.00%> (+<0.01%)	⬆️
e2e quarkus	26.00% <0.00%> (+0.02%)	⬆️
e2e rust	25.47% <0.00%> (+<0.01%)	⬆️
e2e springboot	24.14% <0.00%> (+<0.01%)	⬆️
e2e typescript	25.99% <0.00%> (+<0.01%)	⬆️
e2e-config-ci	26.84% <0.00%> (+<0.01%)	⬆️
integration	15.78% <0.00%> (-0.01%)	⬇️
unit macos-14	42.25% <0.00%> (+<0.01%)	⬆️
unit macos-latest	42.25% <0.00%> (+<0.01%)	⬆️
unit ubuntu-24.04-arm	42.58% <0.00%> (+0.04%)	⬆️
unit ubuntu-latest	43.12% <0.00%> (+<0.01%)	⬆️
unit windows-latest	42.32% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

unrelated to this PR: why we use exec() instead of using Go code, kind/kubectl is Go code. Also why call docker via CLI exec()? Why not API? We already extensively use k8s and docker API already.

unrelated to this PR: why we use exec() instead of using Go code, kind/kubectl is Go code. Also why call docker via CLI exec()? Why not API? We already extensively use k8s and docker API already.

Exactly right! This is simply a stepping-stone. Translating script->Go code with this structure is much less error-prone. Next step is to replace the exec's with code wherever possible! Same way we did with the builders: wrap the cli, get it working, replace with the stdlib 👍🏻

/retest

note from AI: stale comment incmd/cluster.go -> Deletes a local development cluster and its associated registry container 😁

Help still said "registry container" (host-side lifecycle). Match the in-cluster Deployment model: Kind removes the registry with the cluster; host trust reverts only on last func-managed cluster. Functions#43 / knative#3856

🤖 @gauron99 re stale delete help ("registry container"): fixed in f5a260a — docs now match in-cluster registry + last-cluster host-trust revert.

🤖 @matejvasek re your note on exec vs Go APIs: agreed this PR stays on the script→Go stepping-stone. Follow-up for kind/kubectl/docker library calls: #3964

Replace YAML string literals for the in-cluster registry Deployment, Service, Ingress, and local-registry-hosting ConfigMap with typed k8s API objects marshaled via sigs.k8s.io/yaml. Same resources; apply path unchanged (kubectl apply -f -). Addresses matejvasek review on knative#3856. Functions#43

Poll http://127.0.0.1:5000/v2/ until 200 (hostPort path) before create returns, so the first push is less likely to race an unready registry. Uses hostPort rather than registry.localtest.me because Contour installs in parallel with the registry goroutine. Addresses matejvasek review on knative#3856. Functions#43

Used by pkg/cluster for typed registry manifest marshaling. Satisfies hack/update-codegen / verify-deps which require direct deps in go.mod. Functions#43 / knative#3856

/test all

Migrates func cluster create to an in-cluster registry (Deployment + Service + Contour Ingress + local-registry-hosting), matching hack/cluster.sh (knative#3718). Host trust uses registry.localtest.me; containerd mirrors hostPort :5000. Also: - Typed k8s objects for registry manifests (sigs.k8s.io/yaml) - Wait for registry HTTP readiness on 127.0.0.1:5000/v2/ - Delete help + empty-list cleanup (fold #63 CLI path; no host-container teardown) - Promote sigs.k8s.io/yaml to a direct require Rebased onto current main (resolves merge conflict). Functions#43 / knative#3856

C1: restore main's dependency floor (knative#3978); only intentional go.mod delta is promoting sigs.k8s.io/yaml to a direct require (typed registry manifests). S1: remove waitForRegistryHTTP on 127.0.0.1:5000 — Kind does not map host port 5000 (hostPort is node-local for containerd). Rely on kubectl wait --for=condition=Available like hack/cluster.sh. Functions#43 / knative#3856

Tested end-to-end: built from branch, created a default cluster, verified registry deployment, host access via registry.localtest.me, and image push — all working.

Two minor follow-ups filed:

cluster delete: remove dead --container-engine flag #3979 — dead --container-engine flag on delete
cluster create: registry unreachable from host with --serving=false #3980 — registry unreachable from host with --serving=false (no Contour)

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

OWNERS [gauron99,lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cherry-pick release-1.23

@gauron99: new pull request created: #3981

Details

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Delete no longer uses ContainerEngineOverride (teardownRegistry gone; kind delete does not need the engine override). Remove the flag so it does not silently accept a no-op value. Functions#43 / knative#3856

hack/cluster.sh always runs (serving && dns && networking) so Contour is always present for the registry Ingress (contour-external). Go allows --serving=false (e.g. future KEDA-only); without Contour the registry Ingress was inert and host docker push to registry.localtest.me failed. Extract installContour from installNetworking; on the reg path, when Serving is off, install Contour before the registry. Default --serving=true unchanged. Help text documents defaults and that Contour ships with registry. Functions#43 / knative#3856

Parent Long still said "just Kubernetes + registry" for --serving=false; create Long already documents Contour. Match both help surfaces. Functions#43 / knative#3856

…ngine (#3985) Post-#3856 follow-up (review S1/S2 landed after the squash merge): S1: Remove --container-engine from cluster delete — nothing read it after host registry teardown went away. S2: Extract installContour; when --serving=false install Contour before the registry so registry.localtest.me Ingress is not inert. Default --serving=true unchanged (hack/cluster.sh always has Contour via networking). Help text documents Contour on minimal create. Functions follow-up to #43 / #3856

knative-prow Bot requested review from dsimansk and jrangelramos May 26, 2026 07:53

knative-prow Bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels May 26, 2026

lkingland force-pushed the push-qtztqtnuqqqy branch from f96a48b to 0470fa1 Compare May 26, 2026 08:00

matejvasek reviewed May 26, 2026

View reviewed changes

Comment thread CLAUDE.local.md Outdated

matejvasek reviewed May 26, 2026

View reviewed changes

Comment thread pkg/cluster/registry.go Outdated

matejvasek reviewed May 26, 2026

View reviewed changes

Comment thread pkg/cluster/registry.go

matejvasek reviewed May 26, 2026

View reviewed changes

Comment thread pkg/cluster/registry.go

lkingland force-pushed the push-qtztqtnuqqqy branch from 0470fa1 to 05b13f2 Compare May 26, 2026 12:45

gauron99 reviewed Jun 25, 2026

View reviewed changes

Comment thread pkg/cluster/delete.go Outdated

Comment thread pkg/cluster/registry.go

lkingland force-pushed the push-qtztqtnuqqqy branch from 05b13f2 to f5a260a Compare July 25, 2026 10:22

lkingland mentioned this pull request Jul 25, 2026

cluster: replace exec with API calls #3964

Open

lkingland force-pushed the push-qtztqtnuqqqy branch from 472da09 to 76b7338 Compare July 30, 2026 05:49

knative-prow Bot added size/XL 🤖 PR changes 500-999 lines, ignoring generated files. and removed size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels Jul 30, 2026

knative-prow Bot removed the size/XL 🤖 PR changes 500-999 lines, ignoring generated files. label Jul 31, 2026

knative-prow Bot added the size/L 🤖 PR changes 100-499 lines, ignoring generated files. label Jul 31, 2026

This was referenced Jul 31, 2026

cluster delete: remove dead --container-engine flag #3979

Closed

cluster create: registry unreachable from host with --serving=false #3980

Closed

knative-prow Bot assigned gauron99 Jul 31, 2026

knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Jul 31, 2026

knative-prow Bot merged commit fe9cd8a into knative:main Jul 31, 2026
43 checks passed

knative-prow-robot mentioned this pull request Jul 31, 2026

[release-1.23] cluster: migrate registry from host container to in-cluster deployment #3981

Closed

lkingland mentioned this pull request Aug 3, 2026

cluster: Contour when --serving=false; drop dead delete --container-engine #3985

Merged

3 tasks

This was referenced Aug 21, 2026

cleanup: remove container-engine flag from the delete config #3987

Closed

added portmapping for registory to bypass ingress #3988

Closed

cluster: migrate registry from host container to in-cluster deployment by lkingland · Pull Request #3856 · knative/func · GitHub

Uh oh!

cluster: migrate registry from host container to in-cluster deployment - #3856

cluster: migrate registry from host container to in-cluster deployment#3856knative-prow[bot] merged 2 commits intoknative:mainknative/func:mainfrom lkingland:push-qtztqtnuqqqylkingland/func:push-qtztqtnuqqqyCopy head branch name to clipboard

Conversation

lkingland commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

codecov Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matejvasek commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lkingland commented May 28, 2026

Uh oh!

lkingland commented May 31, 2026

Uh oh!

gauron99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lkingland commented Jul 25, 2026

Uh oh!

lkingland commented Jul 25, 2026

Uh oh!

lkingland commented Jul 28, 2026

Uh oh!

gauron99 commented Jul 31, 2026

Uh oh!

knative-prow Bot commented Jul 31, 2026

Uh oh!

Uh oh!

gauron99 commented Jul 31, 2026

Uh oh!

knative-prow-robot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cluster: migrate registry from host container to in-cluster deployment#3856
knative-prow[bot] merged 2 commits into
knative:mainfrom
lkingland:push-qtztqtnuqqqy

lkingland commented May 26, 2026 •
edited
Loading

codecov Bot commented May 26, 2026 •
edited
Loading

matejvasek commented May 26, 2026 •
edited
Loading