Repository navigation
Add yq to list of commands ignored for SC2016 - #3541
Open
gkrimer wants to merge 1 commit into
Open
gkrimer wants to merge 1 commit into
gkrimer wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
gkrimer
marked this pull request as ready for review
September 25, 2026 01:24
lilimarlen074-del
approved these changes
Sep 29, 2026
Copy link
Copy Markdown
Author
|
Alternatively, we can restrict the check to the as $var syntax that yq and jq have for variable declaration. That is a more substantial change, but it would provide a more targeted check. Here is a very WIP prototype of what this might look like: gkrimer#1 Unfortunately gkrimer#1 was generated by Claude, and I don't really know Haskell so I'd need to spend quite a bit more time on it to understand and validate. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach https://www.shellcheck.net/wiki/SC2016 about yq, which also has $var in expressions like jq:
This applies to both mikefarah/yq and kislyuk/yq (a jq wrapper). As with jq, the trade-off is missing '.x = "$VAR"' mistakes.
Written by Claude on behalf of @gkrimer.