fix:add off_t conversion - #106
Open
alexs-sh wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This fix makes bytehound buildable to armv7-unknown-linux-gnueabihf target and runnable on iMX6 boards.
alexs-sh
marked this pull request as ready for review
April 12, 2023 20:00
Copy link
Copy Markdown
|
I recently stumbled upon the same problem, but I think instead of using the bigger type and converting/truncating it, would be to use off_t instead of off64_t, which would make it the correct size for the platform it is compiled for. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@hardliner66 Thanks for the information. I agree. The version with off_t looks better. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
I'm experiencing this same issue, when trying to build this for armv7-unknown-linux-gnueabihf. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here is an example:
error[E0308]: mismatched types --> preload/src/api.rs:79:55 | 79 | mmap_internal( addr, length, prot, flags, fildes, off, MapKind::Jemalloc ) | ------------- ^^^ expected `i64`, found `i32` | | | arguments to this function are incorrect | note: function defined here --> preload/src/api.rs:895:11 | 895 | unsafe fn mmap_internal( addr: *mut c_void, length: size_t, prot: c_int, flags: c_int, fildes: c_int, off: libc::off64_t, kind: MapKind )... | ^^^^^^^^^^^^^ ------------------ help: you can convert an `i32` to an `i64` | 79 | mmap_internal( addr, length, prot, flags, fildes, off.into(), MapKind::Jemalloc ) | +++++++ error[E0308]: mismatched types --> preload/src/api.rs:881:97 | 881 | ptr = syscall::mmap( p0.add( 4096 ), length, prot, flags | libc::MAP_FIXED, fildes, off ); | ------------- arguments to this function are incorrect ^^^ expected `i32`, found `i64` | note: function defined here --> preload/src/syscall.rs:106:15I added fixes to make everything buildable/runnable on the target device and prepared PR for discussion. I'm not sure that it's the correct or expected way to deal with problems.
The issue reproduced in 2 enviroments:
Build command: