Drop a scheduled time the clock cannot show when the settings page loads - #211
ktomy merged 1 commit into
Conversation
Sorry, something went wrong.
Validates default_face and face_schedule rows in /api/save, and drops invalid schedule rows on load. Kept Adam's custom MAC validation.
|
please, please, do all the validations on the client. Let's keep clock's firmware innocent and trustful. In practice this means less complexity in the firmware, it is way easier to debug some javascript than debug some c++ code on a relatively slow hardware. Thanks |
Sorry, something went wrong.
The schedule card is not drawn while the schedule is off, so a row naming a face the clock does not have could not be seen or fixed on the page, and was posted back on every save. normalizeLoaded now drops it, the way it already repairs default_face. A row whose face is only switched off is kept, since the page can draw that one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Agreed, and I see you've already removed the save checks from ServerManager in 61f77f0. I've dropped all the firmware changes from this PR and rebased it onto main. What's left is page-only: when the settings page loads, it drops a scheduled time that names a face the clock doesn't have. While the schedule is off its card isn't drawn, so a bad row couldn't be seen or fixed, and it was saved back every time. A row whose face is just switched off is kept, since the page can show that one. |
Sorry, something went wrong.
Found while working #210. The settings page does not draw the schedule card while the schedule is off, so a scheduled time naming a face the clock does not have could not be seen or fixed there. The page posted it back on every save, and the firmware skips it on load with only a debug line: a setting that never takes effect.
normalizeLoaded now drops such a row when the page loads, the way it already repairs default_face. A row whose face is only switched off is kept, since the page can draw that one and say so.
Page-only: the earlier firmware checks are gone, per the review and 61f77f0. Checked by loading a config with rows naming face 99, no face, and a switched-off face: the first two are dropped and the third kept, while main keeps all three. The page builds.
🤖 Generated with Claude Code