FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support travis pypi deployment by roycaihw · Pull Request #1099 · kubernetes-client/python · GitHub

/ python Public

Support travis pypi deployment - #1099

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
roycaihw:travis-pypi-deploy
Mar 9, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Support travis pypi deployment#1099
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
roycaihw:travis-pypi-deploy

Conversation

roycaihw commented Mar 9, 2020

Copy link
Copy Markdown
Member

ref: https://docs.travis-ci.com/user/deployment/pypi

Travis tooling fixed the indentation. Please review with whitespace change ignored.

I'm not sure if we can test this locally. Once it's merged we should start tagging 10.1.0 release.

roycaihw requested review from fabianvf and palnabarun March 9, 2020 05:21
k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2020
k8s-ci-robot requested a review from yliaog March 9, 2020 05:21

k8s-ci-robot commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2020
palnabarun approved these changes Mar 9, 2020
View reviewed changes

palnabarun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

@roycaihw Shall we test this for a dummy release? Maybe tag this commit itself.

palnabarun commented Mar 9, 2020

Copy link
Copy Markdown
Member

/lgtm

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020

palnabarun commented Mar 9, 2020

Copy link
Copy Markdown
Member

/hold

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020

palnabarun commented Mar 9, 2020

Copy link
Copy Markdown
Member

Adding the hold just for trying it out.

palnabarun commented Mar 9, 2020

Copy link
Copy Markdown
Member

/unassign

Very strange that it assigned me when I did /lgtm

fabianvf commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

/lgtm

palnabarun commented Mar 9, 2020

Copy link
Copy Markdown
Member

/hold cancel

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
k8s-ci-robot merged commit 3792b19 into kubernetes-client:master Mar 9, 2020
roycaihw deleted the travis-pypi-deploy branch March 9, 2020 20:55

micw523 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

@palnabarun The bot automatically assigns you since you lgtm'ed the PR.

This was referenced Mar 12, 2020
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 12, 2020
Merge pull request #1109 from palnabarun/automated-cherry-pick-of-#1099-
973911e 
#1100-#1101-#1102-upstream-release-10.0

Automated cherry pick of #1099 #1100 #1101 #1102
k8s-ci-robot added a commit that referenced this pull request Mar 12, 2020
Merge pull request #1108 from palnabarun/automated-cherry-pick-of-#1099-
6b268fb 
#1100-#1101-#1102-upstream-release-11.0

Automated cherry pick of #1099 #1100 #1101 #1102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

palnabarun palnabarun approved these changes
fabianvf Awaiting requested review from fabianvf
yliaog Awaiting requested review from yliaog

Assignees

fabianvf

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL