i18n: Support SQLAlchemy 2 MappedColumn - #705
Open
madsodgaard wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
atugushev-aghanim
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Thanks! Just bumped into this PR after implementing this by myself.
I could help with the tests if you don't mind to increase the chances of this being merged. What do you think?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use the internalization module with SQLAlchemy and the mapped_column style, you run into the following error:
AttributeError: 'MappedColumn' object has no attribute 'key'.
This adds a workout around by accessing the key though attr.column.key if the attribute is a MappedColumn. Not sure if the implementation is the best approach in terms of providing compatibility with 1.X, so any input would be great!