Fix matchSubdomain function to correctly handle exact domain matches - #2802
Open
suwakei wants to merge 2 commits into
Open
Fix matchSubdomain function to correctly handle exact domain matches#2802suwakei wants to merge 2 commits into
suwakei wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi! Just following up to see if there's anything I can improve in this PR 🙇 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
My two cents: |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I added specific unit test |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi maintainers 👋 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The matchSubdomain function incorrectly returns false for exact domain matches without wildcards—for example, http://example.com vs. http://example.com.
Cause
Even if all parts match during iteration, the function still returns false at the end.
Fix
After the loop, if all parts match and the number of parts is equal between the pattern and the domain, it should return true—i.e., treat it as an exact match.
This PR adds that check.