Router: auto HEAD to GET - #2949
Merged
aldas merged 1 commit intoJul 12, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 97.29730% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #2949 +/- ##
==========================================
+ Coverage 93.17% 93.44% +0.26%
==========================================
Files 43 43
Lines 4501 4712 +211
==========================================
+ Hits 4194 4403 +209
+ Misses 189 188 -1
- Partials 118 121 +3 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Any updates on this ?? |
Sorry, something went wrong.
aldas
force-pushed
the
alternative_heat_to_get
branch
2 times, most recently
from
a1867aa to
58f8903
Compare
June 9, 2026 19:18
vishr
added a commit
that referenced
this pull request
Jun 13, 2026
- Correct net/http interop claim: Echo handlers are not http.Handler; interop is via WrapHandler/WrapMiddleware - Clarify binding ships with a pluggable validator (not built-in validation) - ROADMAP: reference canonical auto-HEAD issue/PR (#2895/#2949) instead of the duplicate PRs (#2944/#2937) slated for closure Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vishr
added a commit
that referenced
this pull request
Jun 13, 2026
* docs: add liveness signals to README and a public ROADMAP - Add dynamic latest-release and last-commit badges (can't go stale) - Add positioning vs net/http and an "actively maintained" note - Add ROADMAP.md with version policy (v5 current, v4 LTS to 2026-12-31) and surface it from the README Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: fix review findings in README/ROADMAP - Correct net/http interop claim: Echo handlers are not http.Handler; interop is via WrapHandler/WrapMiddleware - Clarify binding ships with a pluggable validator (not built-in validation) - ROADMAP: reference canonical auto-HEAD issue/PR (#2895/#2949) instead of the duplicate PRs (#2944/#2937) slated for closure Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 13, 2026
…lling back to the corresponding GET route
aldas
force-pushed
the
alternative_heat_to_get
branch
from
58f8903 to
c97f73c
Compare
July 12, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for alternative solution to #2944 (#2895) - do not register extra routes. use router internals to fallback from head to get. these extra IF checks do not register as meaningful change when running benchstat, but registering another route along with GET looks like a quick hack.
store benchmarks for this change
check out current version
and compare these two
usage:
Create Echo instance with Router that is configured with AutoHandleHEAD = true