FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: fix typos in httperror.go by tisonkun · Pull Request #2958 · labstack/echo · GitHub

/ echo Public

chore: fix typos in httperror.go - #2958

Merged
aldas merged 2 commits into
labstack:masterfrom
tisonkun:fix-typos
May 1, 2026
ConversationCommits (2)ChecksFiles changed
Merged

chore: fix typos in httperror.go#2958
aldas merged 2 commits into
labstack:masterfrom
tisonkun:fix-typos

Conversation

tisonkun commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

chore: fix typos in httperror.go
86d0223 
Signed-off-by: tison <wander4096@gmail.com>
tisonkun commented Apr 27, 2026
View reviewed changes
Comment thread httperror.go Outdated
// Wrap eturns new HTTPError with given errors wrapped inside
func (he HTTPError) Wrap(err error) error {
// Wrap returns a new HTTPError with given errors wrapped inside
func (he *HTTPError) Wrap(err error) error {

tisonkun Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a non-trivial change but it keeps all receivers as pointer receivers. Or else my linter would report:

Struct HTTPError has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation.

aldas May 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well, it is intentional as this Wrap does not mutate the HTTPError instance returns "immutable-copy wrapping"

tisonkun May 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
func (he *HTTPError) Wrap(err error) error {
func (he HTTPError) Wrap(err error) error {

tisonkun commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

@aldas

aldas commented May 1, 2026

Copy link
Copy Markdown
Contributor

Other than that receiver change looks good.

tisonkun commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

Non-trivial change reverted.

aldas approved these changes May 1, 2026
View reviewed changes

aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

codecov Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.08%. Comparing base (22e4b71) to head (b12f646).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2958   +/-   ##
=======================================
  Coverage   93.07%   93.08%           
=======================================
  Files          43       43           
  Lines        4506     4510    +4     
=======================================
+ Hits         4194     4198    +4     
  Misses        195      195           
  Partials      117      117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aldas merged commit 96be504 into labstack:master May 1, 2026
10 checks passed
tisonkun deleted the fix-typos branch May 1, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aldas aldas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL