fix(middleware): only short-circuit CORS preflights - #3064
Closed
deepakganesh78 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Treat OPTIONS requests as CORS preflights only when Origin and Access-Control-Request-Method are present, so non-preflight OPTIONS handlers can run. Fixes labstack#2534 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
deepakganesh78
force-pushed
the
fix/issue2534-cors-preflight
branch
from
4839536 to
ecd917d
Compare
August 2, 2026 15:39
Copy link
Copy Markdown
Contributor
|
closing. This is not be solved for v4. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
If anyone absolutely need it in v4 it can be done with config.Skipper that checks return r.Method == http.MethodOptions &&
r.Header.Get(echo.HeaderOrigin) != "" &&
r.Header.Get(echo.HeaderAccessControlRequestMethod) != "" |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2534.
Reproduction
Echo v4 CORS middleware treated every OPTIONS request as a preflight, so both OPTIONS /hello without Origin and OPTIONS /hello with Origin but without Access-Control-Request-Method short-circuited before a registered OPTIONS handler could run. Added TestCORS_NonPreflightOPTIONSPassThrough, which fails against the old implementation.
Root cause
The middleware used req.Method == http.MethodOptions as its preflight test. Per Fetch, a CORS preflight is an OPTIONS request with both Origin and Access-Control-Request-Method.
Fix
Classify preflights with method + Origin + Access-Control-Request-Method. Non-preflight OPTIONS requests now continue through the handler chain while true preflights keep the existing 204 short-circuit and CORS headers.
Compatibility / behavior change
This intentionally changes non-preflight OPTIONS handling. In addition to OPTIONS requests with Origin but no Access-Control-Request-Method, OPTIONS requests with no Origin now call next(c) instead of being answered directly by CORS with 204 No Content. That is correct because those requests are not CORS preflights, but apps with auth or other middleware in front of non-preflight OPTIONS routes may now see that middleware run.
Validation
AI-assisted with GitHub Copilot CLI.