Feat: KillAura DPS calculation - #200
Merged
emyfops merged 2 commits intoDec 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ult, kept old behavior as another mode.
emyfops
suggested changes
Dec 21, 2025
Comment thread
src/main/kotlin/com/lambda/module/modules/combat/KillAura.kt
Outdated
| @Suppress("unused") | ||
| enum class DamageMode(override val displayName: String) : NamedEnum { | ||
| DPS("Damage Per Second"), | ||
| Total("Hit Damage") |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
You could inline the check in the code inside the enum. Ex:
enum class DamageMode(override val displayName: String, val block: SafeContext.(ItemStack) -> Double) : NamedEnum {
DPS("Damage Per Second", { player.attackDamage(stack = it) * player.attackSpeed(stack = it) }),
}
to then simply sort with the block
Sorry, something went wrong.
emyfops
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't want the KillAura to always switch to the axe if I have swap on, so this fixes that.
It prefers the axe or the tool with the highest damage/hit if it is in the "Hit Damage" mode if you like the old behavior.