C: Support passes - #1636
Merged
Smit-create merged 5 commits intoApr 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
czgdp1807
requested changes
Apr 4, 2023
Comment thread
tests/reference/c-expr_01-28f449f.stdout
| _lpython_return_variable = x&y; | ||
| return _lpython_return_variable; | ||
| } | ||
|
|
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This is not good. Please skip inline function calls pass in C. inline __attribute__((always_inline)) directs the C compiler to do the same and since C language is a high level language so the generated code should be as readable as possible.
Sorry, something went wrong.
czgdp1807
marked this pull request as draft
April 4, 2023 12:42
Smit-create
marked this pull request as ready for review
April 4, 2023 13:45
czgdp1807
approved these changes
Apr 4, 2023
czgdp1807
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looks good. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.