Unsigned integers no wrap II - #2189
Merged
ubaidsk merged 8 commits intoJul 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
These are compile-time cases
certik
reviewed
Jul 19, 2023
Comment thread
tests/reference/asr-unsigned_02-6563e58.stderr
| --> tests/errors/unsigned_02.py:3:10 | ||
| | | ||
| 3 | i: u16 = -u16(5) | ||
| | ^^^^^^^ use -i32(u) for signed result |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
It would be great if it could copy the actual expression inside:
Suggested change
| | ^^^^^^^ use -i32(u) for signed result | |
| | ^^^^^^^ use -i32(5) for signed result |
But I guess for that we would have to have an ASR -> Python printer, which we plan to, but not right now. So we can do that later.
Sorry, something went wrong.
certik
approved these changes
Jul 19, 2023
certik
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks great!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Thank you so much for the quick review! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2173
towards #2176 (comment)