Add get_builder0 macro to declare auxiliary variables at entry point of functions - #2205
Merged
czgdp1807 merged 3 commits intoJul 27, 2023
Merged
Add get_builder0 macro to declare auxiliary variables at entry point of functions#2205czgdp1807 merged 3 commits into
czgdp1807 merged 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
czgdp1807
marked this pull request as ready for review
July 24, 2023 18:36
Copy link
Copy Markdown
Collaborator
Author
|
@certik I think we can merge this. Do you have any reviews that must be addressed before merging this? |
Sorry, something went wrong.
certik
approved these changes
Jul 26, 2023
Copy link
Copy Markdown
Contributor
|
Looks good. The only issue is with using macros in header files. It will sooner or later cause a clash. One must use unique names, like LCOMPILERS_BUILDER_0 or something like that. That can be fixed later. |
Sorry, something went wrong.
czgdp1807
enabled auto-merge (squash)
July 27, 2023 03:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @kabra1110