Further extend the random module - #235
Merged
namannimmo10 merged 8 commits intoMar 23, 2022
Merged
namannimmo10 merged 8 commits into
namannimmo10 merged 8 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Smit-create
reviewed
Mar 15, 2022
Comment thread
src/runtime/random.py
Comment thread
src/runtime/random.py
Comment thread
src/runtime/random.py
Smit-create
reviewed
Mar 15, 2022
Comment thread
src/runtime/random.py
Outdated
Copy link
Copy Markdown
Contributor
|
I noticed the random_float must return f32, not f64: LFORTRAN_API float _lfortran_random_float()
{
return ((float) rand() / (float) RAND_MAX);
} |
Sorry, something went wrong.
certik
reviewed
Mar 23, 2022
Comment thread
src/runtime/random.py
Outdated
certik
reviewed
Mar 23, 2022
Comment thread
src/runtime/random.py
Outdated
certik
approved these changes
Mar 23, 2022
certik
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks good otherwise.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.