feat: add a pixi file and split into two envs (host & build) - #2744
Open
wolfv wants to merge 4 commits into
Open
feat: add a pixi file and split into two envs (host & build)#2744wolfv wants to merge 4 commits into
wolfv wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
certik
reviewed
Jul 25, 2024
certik
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Let's remove pixi.lock for now, because it's huge and will get even bigger for all platforms. This can always be added later.
The move from make to Ninja might also break a few things, but we can fix those as we discover them.
Otherwise good.
Sorry, something went wrong.
Comment thread
build1.sh
| if [[ "$OUTOFTREE" == "true" ]]; then | ||
| mkdir -p build | ||
| cd build | ||
| fi |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Is this needed for pixi build? If so, why not just move this logic to pixi.toml itself? That way this simple script can stay build system independent.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to do some development on lpython.
It might simplify the first steps for some people :) The lockfile should create a consistent environment. I only have tested this on macOS arm64 so far though.
We create two environments:
A start task is also added to run the development version of lpython. I was pretty confused for a while which runtime folder to include so I also added that to the start command (and changed build1.sh).
I can fix this up for linux and windows if you all like it.