change fullname to name - #16
Conversation
Sorry, something went wrong.
Change $console->resgiter default to array
|
@ezhasyafaat I'll check out the issue if it still stands |
Sorry, something went wrong.
|
okay, in my local project i have fixed this issue, but i close the PR because i have PR to master |
Sorry, something went wrong.
|
can you check this again @mychidarko? |
Sorry, something went wrong.
mychidarko
left a comment
There was a problem hiding this comment.
Hey @ezhasyafaat finally got the chance to look through the issue. Actually both schema and migrations use fullname, so those can be left unchanged. The only change needed here is on the User model. You can edit the $fillable field to fullname there.
Like this:
protected $fillable = [
'fullname', 'email', 'password',
];
Sorry, something went wrong.
|
in my local project i try to just change the model user, but i found error again Leaf\Exceptions\ErrorException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'name& (truncated...) |
Sorry, something went wrong.
|
so i think we have to change scaffold auth in repo aloe, what do you think? @mychidarko |
Sorry, something went wrong.
|
What do you have in mind? |
Sorry, something went wrong.
|
In ApiAuth/controller/Auth/RegisterController.php, weh have to change $credentials = request()->get(['username', 'name', 'email', 'password']);
$validation = Form::validate([
'name' => 'required',
'username' => ['username', 'max:15'],
'email' => 'email',
'password' => 'min:8'
]);to $credentials = request()->get(['username', 'fullname', 'email', 'password']);
$validation = Form::validate([
'fullname' => 'required',
'username' => ['username', 'max:15'],
'email' => 'email',
'password' => 'min:8'
]); |
Sorry, something went wrong.
|
i can do it this in this repo protected $fillable = [
'fullname', 'email', 'password',
];and i can do it this in aloe repo $credentials = request()->get(['username', 'fullname', 'email', 'password']);
$validation = Form::validate([
'fullname' => 'required',
'username' => ['username', 'max:15'],
'email' => 'email',
'password' => 'min:8'
]); |
Sorry, something went wrong.
|
Oh yeah, right. In the controller as well |
Sorry, something went wrong.
|
okay i will fix it now |
Sorry, something went wrong.
Description
Change key fullname on scheme/user.json to name
Related Issue
I found some error when i was try to create user from API, its because in scheme/user.json use key "fullname", but in model search for column "name"