FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add support for jpms by sgammon · Pull Request #29 · leangen/geantyref · GitHub

/ geantyref Public
forked from coekie/gentyref

feat: add support for jpms - #29

Merged
kaqqao merged 1 commit into
leangen:masterfrom
javamodules:feat/jpms
Sep 1, 2024
ConversationCommits (1)ChecksFiles changed
Merged

feat: add support for jpms#29
kaqqao merged 1 commit into
leangen:masterfrom
javamodules:feat/jpms

Conversation

sgammon commented Mar 16, 2024 •
edited
Loading

Copy link
Copy Markdown

Summary

Adds a module-info.java so that Geantyref can be used from Modular Java apps.

Fixes and closes #28 and #26

Changelog

  • chore: add mvn build wrapper
  • chore: add compile run and srcroot for java9
  • chore: add java9-compliant implementations where needed
  • chore: add mrjar output
  • chore: remove Automatic-Module-Name

sgammon mentioned this pull request Mar 16, 2024
Open
sgammon added a commit to elide-dev/jpms that referenced this pull request Mar 16, 2024
feat: add io.leangen.geantyref
9e8f491 
Adds the `io.leangen.geantyref` project to the repository, after
applying PR leangen/geantyref#29

Relates-To: leangen/geantyref#29
Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon mentioned this pull request Mar 16, 2024
Merged
sgammon added a commit to elide-dev/jpms that referenced this pull request Mar 16, 2024
feat: add io.leangen.geantyref (#30)
59d876f 
Adds the `io.leangen.geantyref` project to the repository, after
applying PR leangen/geantyref#29

Relates-To: leangen/geantyref#29

Signed-off-by: Sam Gammon <sam@elide.ventures>

kaqqao commented Aug 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Hi @sgammon!
Thanks for this. Java 8 is ancient enough that I'd rather drop support for it and make this 9+ only. And, to be honest, I don't really want to maintain a multi-release. Would you mind changing your PR to accommodate for that?

kaqqao self-requested a review August 18, 2024 10:25

sgammon commented Aug 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

@kaqqao happy to do so :)

feat: add support for jpms
f108b3a 
- chore: add mvn build wrapper
- chore: add java9-compliant implementations where needed
- chore: remove `Automatic-Module-Name`

Fixes and closes leangen#28

Signed-off-by: Sam Gammon <sam@elide.ventures>

sgammon commented Aug 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

@kaqqao Okay, I've pushed so that only the JPMS changes are included. Geantyref is now Java 9+ only. Some overrides needed to be added to comply with Java 9+ APIs, and I took the liberty of adding the mvnw wrapper. Otherwise the PR is very clean.

I have been testing downstream in the JPMS Attic repo; this lets me exercise Geantyref against libraries that use it, with these changes applied. I'll report back if I encounter any issues. I expect tests to pass.

sgammon mentioned this pull request Aug 18, 2024
Merged
kaqqao merged commit d789fe6 into leangen:master Sep 1, 2024

kaqqao commented Sep 1, 2024

Copy link
Copy Markdown
Member

@sgammon Merged this, added the real implementations for the API introduced in Java 9 and released this as v2.0.0 🚀

sgammon commented Sep 1, 2024

Copy link
Copy Markdown
Author

Thank you @kaqqao! 🥳

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kaqqao Awaiting requested review from kaqqao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add module-info.java

2 participants

Back | FazBrowse Home | New Git URL