FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Multiple reports by dannylewis-sheffield · Pull Request #22 · leanphp/behat-code-coverage · GitHub

Multiple reports - #22

Open
dannylewis-sheffield wants to merge 3 commits into
leanphp:masterfrom
openbuild-sheffield:multiple-reports
Open

Multiple reports#22
dannylewis-sheffield wants to merge 3 commits into
leanphp:masterfrom
openbuild-sheffield:multiple-reports

Conversation

Copy link
Copy Markdown
Contributor

Added the option to allow multiple reports.

Sample behat.yml:

        format:
            - html
            - clover
        output:
            html:
                target: public/coverage-behat
            clover:
                target: clover/behat.xml

I've left the original report option as is, so no breaking changes.

ek9 commented Mar 17, 2018

Copy link
Copy Markdown
Member

Hi,

Thank you for the PR. There are a few problems:

  1. The code update is very messy in ReportService.php. The nested if/then/else is unclean and there should be a more clean way to handle this.
  2. The code style is very different from the current coding style that project is using. I have made Add conding style guide and checker #25 so we have code style checks as part of the Travis.
  3. The travis build for your update contains errors (the tests fail). The tests must be fixed.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL