Decouple js/package.json version from setuptools-scm - #234
Merged
rtibbles merged 1 commit intoAug 4, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
`make build` regenerated the version from git tags, so the tracked value could never match what setuptools-scm computes once a release tag exists: the tag lands on a commit whose package.json predates it. Every commit after a release failed `prek run --all-files` — after v0.2.18 the rebuild-from-specs hook rewrote 0.2.18 to 0.2.19 and reported a diff. Version writing moves to scripts/set_npm_version.py, run only by `make release-npm`; the tracked value is a 0.0.0 placeholder. It now rejects non-release versions instead of truncating them to X.Y.Z, so a publish from an untagged checkout can't ship a version that corresponds to no release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014BmsXSofh7NSy7MTVgXa6P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using setuptools-scm means that the version is now dynamic based on the most recent git tag
This broke linting because it would regenerate the npm package version
Fix this by no longer regenerating the npm version except at publish
The committed version is pinned to 0.0.0 - publishing generates and pushes the actual version
References
First seen: #230 — linting has failed on every PR opened since v0.2.18 was tagged.
Prior workaround: c4cdf70.
Reviewer guidance
AI usage
Used Claude Code to diagnose the lint failure from the CI logs and write the fix, including splitting the version write into its own script rather than adding a flag to the spec generator. Verified with prek over all files (both normally and under a simulated post-release tag), the test suite, and manual exercise of the version guard.