fix minor unreachable code caused by t.Fatal - #6283
Merged
aarongable merged 1 commit intoAug 12, 2022
Merged
aarongable merged 1 commit into
aarongable merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aarongable
reviewed
Aug 10, 2022
aarongable
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good catch! Rather than deleting this line, please move it above the t.Fatal() call.
Sorry, something went wrong.
beautifulentropy
requested changes
Aug 10, 2022
Comment thread
reloader/reloader_test.go
Copy link
Copy Markdown
Contributor
Author
Done. Thanks for review. |
Sorry, something went wrong.
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
aarongable
approved these changes
Aug 11, 2022
beautifulentropy
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abirdcfly fp544037857@gmail.com