Fix malformed package.xml for ROS2 colcon builds - #80
Closed
lsk567 wants to merge 13 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The package.xml had two <package> root elements which is invalid XML. This caused colcon to fail to parse it, preventing ROS2 builds from finding the reactor-cpp package. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lsk567
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Jan 20, 2026
Points to lf-lang/reactor-cpp#80 which fixes the malformed package.xml that was causing ROS2 colcon builds to fail. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
Detect ament during ROS2 builds and export targets so reactor-cpp is discoverable by ament_target_dependencies.
Use a standard target export name so ament generates reactor-cppConfig.cmake for downstream find_package calls.
When using ament, ament_package() should handle installing the export files and generating the Config.cmake. The explicit install(EXPORT ...) was interfering with this, causing find_package(reactor-cpp) to fail in downstream packages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The ament_package() generated Config.cmake includes the export targets file, so we need to install it. The previous fix incorrectly removed this when using ament. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Match the pattern used by rclcpp and other ROS2 packages: - Use PROJECT_NAME as export name instead of PROJECT_NAME + Targets - Add ament_export_libraries for legacy CMake compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Clean up debug output that was added during ROS2/ament build troubleshooting. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code