attr: ensure lookups are on repo-relative paths · libgit2/libgit2@9099230 · GitHub

libgit2 / libgit2 Public

• Notifications You must be signed in to change notification settings
• Fork 2.7k
• Star 10.6k

• Code
• Issues 424
• Pull requests 128
• Discussions
• Actions
• Projects
• Security and quality 11
• Insights

Additional navigation options

Commit 9099230

Browse filesBrowse the repository at this point in the historyBrowse files

ethomson

committed

attr: ensure lookups are on repo-relative paths

Attribute lookups are done on paths relative to the repository. Fail if erroneously presented with an absolute path.

1 parent 109d3a1 commit 9099230
Copy full SHA for 9099230

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • attr.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/attr.c‎

Copy file name to clipboardExpand all lines: src/attr.c

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -629,13 +629,13 @@ static int collect_attr_files(
629	629	const char *workdir = git_repository_workdir(repo);
630	630	attr_walk_up_info info = { NULL };
631	631
	632	+ GIT_ASSERT(!git_path_is_absolute(path));
	633	+
632	634	if ((error = attr_setup(repo, attr_session, opts)) < 0)
633	635	return error;
634	636
635	637	/* Resolve path in a non-bare repo */
636	638	if (workdir != NULL) {
637		- GIT_ASSERT(!git_path_is_absolute(path));
638		-
639	639	if (!(error = git_repository_workdir_path(&dir, repo, path)))
640	640	error = git_path_find_dir(&dir);
641	641	}

0 commit comments

Comments

0 (0)