Expose diff whitespace settings - #2007
Open
darthkurak wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
GrimRob
approved these changes
Apr 26, 2023
amis92
reviewed
Feb 28, 2024
Comment thread
LibGit2Sharp/Diff.cs
Comment on lines
+61
to
+75
| if (compareOptions.WhitespaceMode != null) | ||
| { | ||
| if (compareOptions.WhitespaceMode == DiffWhitespaceMode.IgnoreAllWhitespaces) | ||
| { | ||
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE; | ||
| } | ||
| else if (compareOptions.WhitespaceMode == DiffWhitespaceMode.IgnoreWhitespaceChange) | ||
| { | ||
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE_CHANGE; | ||
| } | ||
| else | ||
| { | ||
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE_EOL; | ||
| } | ||
| } |
Copy link
Copy Markdown
There was a problem hiding this comment.
Just a thought:
Suggested change
| if (compareOptions.WhitespaceMode != null) | |
| { | |
| if (compareOptions.WhitespaceMode == DiffWhitespaceMode.IgnoreAllWhitespaces) | |
| { | |
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE; | |
| } | |
| else if (compareOptions.WhitespaceMode == DiffWhitespaceMode.IgnoreWhitespaceChange) | |
| { | |
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE_CHANGE; | |
| } | |
| else | |
| { | |
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE_EOL; | |
| } | |
| } | |
| if (compareOptions.WhitespaceMode == DiffWhitespaceMode.IgnoreAllWhitespaces) | |
| { | |
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE; | |
| } | |
| else if (compareOptions.WhitespaceMode == DiffWhitespaceMode.IgnoreWhitespaceChange) | |
| { | |
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE_CHANGE; | |
| } | |
| else if (compareOptions.WhitespaceMode == DiffWhitespaceMode.IgnoreWhitespaceEol) | |
| { | |
| options.Flags |= GitDiffOptionFlags.GIT_DIFF_IGNORE_WHITESPACE_EOL; | |
| } |
Sorry, something went wrong.
Copy link
Copy Markdown
No I don't have write access |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@bording can we ask you to merge this? It would help a lot as we had to use a forked version for the last year. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
There's also a similar PR from the original issue's OP: #1779 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #1778