| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Hello, what's next for this pull request ? |
Sorry, something went wrong.
Someone needs to review and approve it I guess. Not sure if this is something @bording could do? |
Sorry, something went wrong.
|
@amirvenus Do you have write-access and can get this merged? |
Sorry, something went wrong.
|
Do the unresolved comments block this PR? If the original creator is not around to address them, would it be acceptable for someone else to take over and create a new PR? |
Sorry, something went wrong.
|
so what are the news about this PR? |
Sorry, something went wrong.
|
If practical or required, I'm available to help. Just LMK what I can do. We are streaming git repo state across a distributed CD/CI system and shallow clones dramatically reduce our bandwidth needs. |
Sorry, something went wrong.
|
Is there any updates on this PR? |
Sorry, something went wrong.
|
Just to repeat @YanisThePie 's question from earlier. Are any of the comments on the PR actually blocking the merge? I think there may be some arguments that this could go through as it is. If a maintainer could provide feedback and clarify whether adjustments are needed that would be great. If indeed necessary I would be happy to open up a new PR if @andersklepaker is no longer dealing with this. |
Sorry, something went wrong.
|
Thanks for the comments @karlschriek
Yeah that would be great, and if so happens I'll finish up the work needed for this PR. I did not prioritize investing time here since this repo seems mostly inactive, sadly :( |
Sorry, something went wrong.
|
Are there any further updates? It would be greatly appreciated if this PR could be merged soon assuming there are no open comments or code changes required. |
Sorry, something went wrong.
|
Please, can someone do something about this forgotten PR?... @amirvenus could you merge this please? |
Sorry, something went wrong.
|
thanks @amirvenus for your approval! Are there still steps to go through before the PR is merge? |
Sorry, something went wrong.
|
@karlschriek I think this PR can now be completed? 🤞 |
Sorry, something went wrong.
|
Please merge. We have been missing this feature :) |
Sorry, something went wrong.
|
Would also appreciate if this can be merged |
Sorry, something went wrong.
|
It would be great if this could be merged. |
Sorry, something went wrong.
|
Is this git repo still maintained? |
Sorry, something went wrong.
|
This repo is still maintained even tho it is moving very slow. It's a open source project and we can't demand anything. Maintainers are free to do whatever they like, and that is totallly fine. But i'll admit that some kind of feedback from the maintainers would probably not hurt, as a few people have spent time on this PR. |
Sorry, something went wrong.
|
Hey everyone. @andersklepaker gets to the heart of things. I'm pretty much the only one left who maintains this repo these days, and I just don't have much free time to devote to it. This PR does seem to be one that a lot of people are asking for, so I'll try and review it soon. |
Sorry, something went wrong.
|
Thanks a lot @bording. This merge would enable some interesting scenarios, e.g. saving time and space fetching new repositories, so I'm looking forward to the review as well. |
Sorry, something went wrong.
|
Thanks for the PR and thanks for your patience! |
Sorry, something went wrong.
|
@bording thanks for your hard work on this amazing project ! |
Sorry, something went wrong.
Thanks to libgit2#2070, it is now possible to Clone with shallow depth. In some cases you'd want to unshallow. The current workaround is to delete the local repo and re-Clone with full depth. To avoid this un-necessary step, the Depth could be respected by Fetch, the same way it is doing it for Clone. This patch works for the cases I tested (don't forget to check `repo.Info.IsShallow`), but it seems too simple and I don't know what would be required to test and implement it properly. So I'd like to ask for help on this, thanks.
| Back | FazBrowse Home | New Git URL |
This PR adds Depth to FetchOptions allowing for shallow cloning.
Since I'm new to this repo and it's complexity it's possible i've missed some key information to why this have not been implemented, and if so I'm sorry for not reading up on it prior to submitting this PR.
Resolves #229