Support libssh2 based callbacks - #2182
Conversation
Sorry, something went wrong.
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks Condition="'$(TargetFrameworks)'==''">net472;net8.0;net9.0</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(TargetFrameworks)'==''">net10.0</TargetFrameworks> |
There was a problem hiding this comment.
Bunch of changes to get it building locally
Sorry, something went wrong.
| @@ -0,0 +1,141 @@ | |||
|
|
|||
There was a problem hiding this comment.
This methods are required to be able to call down into the c libraries methods that are only available when using libssh2. The files in this class can be properly tidied up and split up before merge
Sorry, something went wrong.
| private static string nativeLibraryPath; | ||
| private static bool nativeLibraryPathLocked; | ||
| private static readonly string nativeLibraryDefaultPath = null; | ||
| private static readonly string nativeLibraryDefaultPath = "/Users/robert/Development/Sandbox/libgit2/build"; |
There was a problem hiding this comment.
Obviously not something to merge, just that helped testing against my local build of libgit2
Sorry, something went wrong.
| /// <summary> | ||
| /// Options controlling ListRemote behavior. | ||
| /// </summary> | ||
| public sealed class ListRemoteOptions |
There was a problem hiding this comment.
New ListRemoteOptions required to get appropriate handlers on the network list operation
Sorry, something went wrong.
There was a problem hiding this comment.
This can probably be put in as its own PR back into the upstream repo as its not really dependant on anything ssh
Sorry, something went wrong.
| Ensure.ArgumentNotNull(remote, "remote"); | ||
|
|
||
| return ListReferencesInternal(remote.Url, null, new ProxyOptions()); | ||
| var options = new ListRemoteOptions() |
There was a problem hiding this comment.
There are a bunch of overloads in this network class to utilize the new ListRemoteOptions, these dont necessarily need to be implemented exactly like this
Sorry, something went wrong.
| types |= SupportedCredentialTypes.Default; | ||
| } | ||
|
|
||
| if (credTypes.HasFlag(GitCredentialType.SshKey)) |
There was a problem hiding this comment.
To cater for the different credential callback for ssh commands these new enum values need to be catered for here
Sorry, something went wrong.
This PR is not intended to be merged as-is