Crash in git_transport_register - #82
Open
MagicalTux wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…en newly registered transport is actually called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git_transport_register will register a callback, then free said callback before returning, resulting in a crash when said callback is to be used.
This patch removes the call to php_git2_cb_free(), and also implements a new helper php_git2_cb_init_copy() that will duplicate fci/fcc (to be freed in php_git2_cb_free if needed).
Ideally we should also free the callback in the unregister method - but considering most transports are likely to survive until the end of execution of the script that might have a lower priority.