Use a more explicit way of correctly disposing git_strarray when we're using ruby strings - #999
Merged
carlosmn merged 3 commits intoFeb 28, 2026
Merged
carlosmn merged 3 commits into
carlosmn merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…rray` In the latter we make use of the pointers provided to use by ruby and its string types, so we do not allocate memory for the strings themselves. This is different from what libgit2 expects and so we end up using `xfree(x.strings)` which also looks wrong as we're not looking at the actual strings. Provide this dispose function to make it clearer that we are doing the right thing and which also zeroes out the values in the `git_strarray`.
The only difference here is we don't want to accept a single value so we check the type before calling the function.
This makes it clear that we are freeing correctly in the places where we re-used the strings from ruby.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use rugged_rb_ary_to_strarray, we make use of StringValueCStr to get a pointer to the ruby memory, which we then use to fill in the char** that we did allocate to keep the pointers in.
We cannot use git_strarray_dipose as that assumes we own all the memory and it will try to free ruby's memory. We instead have been using xfree(x.strings) which is correct but looks like it isn't, because we're not touching the actual pointers to the string. We also don't zero out the values though in practice that shouldn't matter where we use it.
Here we add rugged_strarray_dispose which makes it clear that we are using the right thing paired with ruged_rb_ary_to_strarray.