FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: resolve long-deferred FIXMEs for Lift 5.0 by farmdawgnation · Pull Request #2053 · lift/framework · GitHub

/ framework Public

fix: resolve long-deferred FIXMEs for Lift 5.0 - #2053

Merged
farmdawgnation merged 2 commits into
lift-5.0from
msf/fixme-candidates-lift5
Apr 7, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix: resolve long-deferred FIXMEs for Lift 5.0#2053
farmdawgnation merged 2 commits into
lift-5.0from
msf/fixme-candidates-lift5

Conversation

farmdawgnation commented Apr 4, 2026

Copy link
Copy Markdown
Member

Mailing List thread:
REPLACE THIS WITH ML LINK

Resolves four FIXMEs that were explicitly deferred to a future major version, now that Lift 5.0 is the target:

  • LiftServlet: Remove runFunction from the finally block in handleGenericContinuation — it was only kept there for 3.x backwards compatibility and now correctly runs only after a successful suspend().
  • CSSHelpers → CssHelpers: Breaking rename for consistent capitalization across Lift (the FIXME noted this required a major version); updates all internal call sites and tests.
  • SHtml: Remove stale "graceful fallback for non-HTML5 browsers" FIXME text from 10 Scaladoc blocks and 3 inline comments on Autofocus, Required, and Placeholder — browser detection for HTML5 fallback is permanently obsolete.
  • Templates / Menu: Remove the scala.language.existentials import workaround for SI-6541, a Scala 2.10/2.11 compiler bug that was fixed in 2.12; the project now targets Scala 2.13 and 3.3.

farmdawgnation and others added 2 commits April 4, 2026 14:02
fix: resolve long-deferred FIXMEs for Lift 5.0
fcd3934 
- Remove runFunction from LiftServlet finally block (explicitly held for next major version)
- Rename CSSHelpers → CssHelpers for consistent capitalization (breaking change, appropriate for 5.0)
- Remove stale HTML5 browser-detection FIXME comments from SHtml Scaladocs
- Remove scala.language.existentials SI-6541 workaround (fixed since Scala 2.12)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chore: merge origin/lift-5.0; resolve CssHelpersSpec conflict
bff57ad 
upstream dropped Scala 2.13 (fa56024), so the scala-2.13 test file
is deleted in favour of the consolidated scala/ version.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
farmdawgnation merged commit 91b46a5 into lift-5.0 Apr 7, 2026
5 checks passed
farmdawgnation deleted the msf/fixme-candidates-lift5 branch April 7, 2026 01:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL