fix(sanity): live preview service is called before be initialized in v18 - #12
Merged
osnoser1 merged 1 commit intoFeb 22, 2025
Merged
fix(sanity): live preview service is called before be initialized in v18#12osnoser1 merged 1 commit into
osnoser1 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
✅ Deploy Preview for limitless-angular-sanity-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
View your CI Pipeline Execution ↗ for commit 048872a.
☁️ Nx Cloud last updated this comment at 2025-02-22 05:39:18 UTC |
Sorry, something went wrong.
Copy link
Copy Markdown
npm i https://pkg.pr.new/@limitless-angular/sanity@12 commit: 048872a |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the new behavior?
This PR fixes a timing issue with the LivePreviewService initialization in v18 introduced by #9. Previously, the service was initialized effect(), which cause race conditions or initialization delays. The change add this with Angular's afterNextRender() that previously worked in v19 while it maintains the effect for v19, ensuring that:
Does this PR introduce a breaking change?
What gif best describes this PR or how it makes you feel?
[A "Perfect Timing" gif would be appropriate here since this PR fixes a timing-related issue]
