fix(e2e): let Playwright own Studio servers - #40
Merged
osnoser1 merged 1 commit intoJun 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
osnoser1
marked this pull request as ready for review
June 8, 2026 17:10
Copy link
Copy Markdown
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
No linked issue.
What is the new behavior?
Playwright now starts the Sanity Presentation E2E preview and Studio servers directly with package-local pnpm --dir ... exec ... commands, passing server-specific values through Playwright's structured env option. This removes the nested turbo run serve persistent-task layer from Playwright's webServer lifecycle so Playwright can tear down the servers it starts.
The CI workflow no longer manually kills ports 4200 and 3333 between Presentation E2E runs because the servers are now owned and cleaned up by Playwright.
Does this PR introduce a breaking change?
Other information
Validated with:
After the hermetic Studio E2E run finished, ports 4200 and 3333 were no longer listening.
[Optional] What gif best describes this PR or how it makes you feel?